Add ALL Methods for Users Endpoints#268
Merged
Merged
Conversation
Enovotny
requested changes
Mar 6, 2026
…sers.sql baked in
- q0hectest key works for normal data, but user-management
endpoints require CWMS User Admins; l2hectest is a better
default for these tests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ommits with that eol
…gicEngineeringCenter/cwms-python into 266-add-create-method-for-user-management
Collaborator
Author
|
Requires For the integration tests to complete, they are hanging on the locations and to ensure |
…onfirm admin role
Collaborator
Author
|
Tests all clear for the users endpoint (Pending that one commit below) Two points:
resolves the full key being seen |
krowvin
changed the title
Collaborator
what about this fail? FAILED tests/cda/users/users_CDA_test.py::test_get_user_403_has_friendly_message_for_missing_roles - Failed: DID NOT RAISE <class 'cwms.api.PermissionError'> |
Collaborator
|
Collaborator
Author
|
Resolved
|
|
Enovotny
approved these changes
Mar 11, 2026
Enovotny
pushed a commit
to HydrologicEngineeringCenter/cwms-cli
that referenced
this pull request
Apr 2, 2026
~Draft until~ - HydrologicEngineeringCenter/cwms-python#268 ~is~ merged. This adds the docs and methods for managing user roles (add/delete) `cwms-cli users roles` ```bash Lists the current available roles ``` `cwms-cli users roles -h` ```bash Commands: add Add one or more roles to an existing user delete Remove one or more roles from an existing user ``` ```bash Usage: cwms-cli users roles add [OPTIONS] Version: 0.3.2 Add one or more roles to an existing user Options: --user-name TEXT Existing user name. --roles TEXT Role name(s) to add. Repeat the option or pass a comma- separated list. -h, --help Show this message and exit. ``` ``` ```bash Usage: cwms-cli users roles delete [OPTIONS] Version: 0.3.2 Add one or more roles to an existing user Options: --user-name TEXT Existing user name. --roles TEXT Role name(s) to add. Repeat the option or pass a comma- separated list. -h, --help Show this message and exit. ``` --------- Co-authored-by: Eric Novotny <nov00002@umn.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created store and update methods and their tests.
Will need #267 in order for all tests to show green/complete